commit comments are not quoted

Hm...looks like an escaping issue. Gotta look into it.

Hi, are you working on windows? I tried your commit message on my linux box and it returned correctly:

/usr/local/bin/hg commit -u Bastian Doetsch -m added "What's new" -- /home/basti an/runtime-EclipseApplication?/dummy/lulu

Done in 0:00.182 min.

test with <" this message " is perhaps \" not quoted 'correctly"""> the message should be everyting within < and > and show up like that in the log (preferably)

no problem console outputs the following:

/usr/local/bin/hg commit -u Bastian Doetsch -m " this message " is perhaps \" no t quoted 'correctly""" -- /home/bastian/runtime-EclipseApplication?/dummy/lulu

Done in 0:00.544 min.

the log entry is okay as well.

in r802 there is a testcase wich fails when using

HgCommitClient?.commit(hgroot, files, "Trasan 'O Banarne", "is this message \" really

but not when using

HgCommitClient?.commit(hgroot, files, "Simple", "the message");

The commit method is new created by refactoring , breaking out the the previous code after sorting by hgroot

in r803 I fixed the internal path problem which made the simple testcase also fail

this may be fixed in r804, someone please review this patch since the commitProject metohd may now be broken

I don't think r804 does it correctly - it only provides file-based commits, not repository commits without filenames.

actually, I changed commitProject to call the same method to reduce duplicate code, and it is my understanding that passing an empty list of files is just as good as a null value since in the actual HgCommand? it will be just the same. What I thought may be broken is that commitProject passed false in escape files, and now I pass true.

This may be or may not be ok, but it should be of no consequence

224 if (escapeFiles && !files.isEmpty()) {
223 	result.add("--");
224 }
225 result.addAll(files);

or are you refering to something else?

then it should be okay and we can close this ticket :-).

so was the error reproducable on linux as well, or only on windows?

Don't know, don't have access to linux box atm. But you can hg up -C 803 and run the testcase

test/com/vectrace/MercurialEclipse/commands/HgCommitClientTest.java

and see if public void testCommitMessageWithQuote() fails

just fixed a bug in commit. user is always null until we get a user field into the commit dialog. so it wasn't possible to commit.

There's one bug left: commit messages now have quotation marks :-(. Could you please have a look at it?

All commit messages have quotation marks? Or only single worded messages? I'll may not be able to look into it until monday.

as far as I can see, all have. See r816 and r817.

remove the two "\"" from the quote method, since this is done automatically

http://sdfgdfg.freehostingz.com/index1.html infotronics attendance enterprise